I initially tried to communicate with the author of the PR, but had no response. However if I'm wrong I'll gladly eat my words so I'll test it out and report back.Īs for the Metal topic that came up for some inexplicable reason, we had a Metal implementation submitted three or four years ago. I'll check to see if changing that around affects anything but I doubt it.Īlthough you're in the correct area of code, I don't think either of those things are relevant to the performance issue. If (!arr.count & !find_window(&wc->window, NULL, false)),īut that's not really relevant either as CGWindowListCreateImage will return a safe-to-use value in either case. If (arr.count || !find_window(&wc->window, NULL, false)) instead of Of course one could argue that maybe it should be It's harmless and is very unlikely to have anything to do with the issue. The duplicate call you're talking about is just a redundant call. Unfortunately, we haven't heard back from that individual. However, again I will test it to be safe, as stranger things have happened.Īdditionally, I'd like to point out that in the subsequent mantis issue you link, Netizen01 that you yourself reference does not state that it has anything to do with CGRectNull, but instead states: I'm guessing it has more to do with threads and shared image buffers, which to me sounds like a more plausible explanation. I could of course be wrong, and Apple could be doing something unpleasant when you use CGRectNull, but that feels unlikely. I don't mind checking to verify if CGRectNull contributes to performance issues with window capture, but with a parameter like that, considering it's a four-integer rectangle structure, I feel doubt considering all it should be expected to do internally is just automatically calculate the rectangle for you. Perhaps it's a bit poorly worded in the documentation, but if you have one window in the window list, it will return an image with a rectangle that is equal to the size of that one window, otherwise window capture would not be capturing anything at all. In the documentation for CGWindowListCreateImage(), using CGRectNull specifies that it will automatically use the minimum required size to capture the specified windows in the window list, that's all. Keep unnecessarily provocative comments and opinions away from our issue reports please, as all it does is seek to provoke and detract from any actual issue there may be.įor the actual issue, if we are doing something that can be improved with window capture, then I definitely want to know about it.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |